hangman: Wondering why remaining_guesses vs get_status() #1910

Activity

1. cmccandless commented on Sep 9, 2019

   

   cmccandless

   on Sep 9, 2019

   Contributor

   More actions

   It wasn't specifically called out in the implementing PR (#1690) one way or the other.

   If @junming403 is available for comment, that would be the only way to gain more insight.
2. petertseng commented on Sep 10, 2019

   

   petertseng

   on Sep 10, 2019

   MemberAuthor

   More actions

   Since that is the course of action and this issue does not appear to need maintainer action, let me close it to get it out of the track's issue queue. Explanations are still welcomed of course even after it is closed.
3. petertseng

   closed this as completedon Sep 10, 2019
4. petertseng commented on Sep 10, 2019

   

   petertseng

   on Sep 10, 2019

   MemberAuthor

   More actions

   I turned to online style guides to answer the question in the issue, and found http://google.github.io/styleguide/pyguide.html#315-access-control

   If an accessor function would be trivial, you should use public variables instead of accessor functions to avoid the extra cost of function calls in Python. When more functionality is added you can use property to keep the syntax consistent.

   On the other hand, if access is more complex, or the cost of accessing the variable is significant, you should use function calls (following the Naming guidelines) such as get_foo() and set_foo().

   Now I understand.

   👍React with 👍1Reacted by Corey McCandless