Skip to content

Investigate issues with configlet lint in Travis-CI builds #1691

Closed

Description

@cmccandless

As observed in #1690 (comment), configlet lint may not be catching everything it is supposed to in our Travis builds (latest build as of this writing passed without issue).

It is unlikely that the issue is with configlet itself, as that same tool was used to find the very violations that CI builds missed, so there is probably an issue with how the builds are configured.

Activity

  1. self-assigned this
    on Feb 26, 2019
  2. cmccandless commented on Mar 7, 2019

    @cmccandless
    ContributorAuthor

    @junming403 Can you confirm what version of configlet you used to lint in #1690?

  3. junming403 commented on Mar 7, 2019

    @junming403
    Contributor

    There is a script fetch-configlet in code base.

  4. cmccandless commented on Mar 7, 2019

    @cmccandless
    ContributorAuthor

    After further investigation: I have determined there is no issue with configlet lint. The issues found in #1690 were changes made by config fmt, and are not called out by configlet lint.

    @junming403 can you please confirm that you did run configlet fmt . in #1690?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions