Repository navigation
bowling: negative test uses positive value #1371
Description
In the "bowling/bowling_test.py" file there is a test that is testing a positive integer where (in the canonical data) it should be testing -1.
def test_rolls_cannot_score_negative_points(self):
with self.assertRaisesWithMessage(ValueError):
self.game.roll(11)That last line should read:
self.game.roll(-1)
Activity
[-]Python "bowling" test issue.[/-][+]bowling: negative test uses positive value[/+]mrcfps commentedon Apr 10, 2018
Nice catch! Since manually constructing test files from canonical data is error-prone, maybe we should pay more attention to automated test generators?
cmccandless commentedon Apr 10, 2018
@mrcfps on the subject, see #1093
Python "bowling" test issue. (#1372)
cmccandless commentedon Apr 11, 2018
Closed in #1372
Merge upstream/master into react-1257
react: Update tests to v2.0.0 (#1346)