Skip to content

improve zipper tests - #839

Merged
SleeplessByte merged 3 commits into
exercism:masterfrom
joshgoebel:zipper_test
Dec 24, 2020
Merged

SleeplessByte merged 3 commits into
exercism:masterfrom
joshgoebel:zipper_test

Conversation

@joshgoebel

@joshgoebel joshgoebel commented Mar 8, 2020 •

Copy link
Copy Markdown
Contributor

Resolves #838

@joshgoebel

Copy link
Copy Markdown
Contributor Author

@SleeplessByte Like this?

@SleeplessByte

Copy link
Copy Markdown
Member

Yeah, this looks fine. Maybe also add the README change through a hint!

@joshgoebel

Copy link
Copy Markdown
Contributor Author

I'm not sure exactly what you want it to say, but you're welcome to edit it and add whatever.

@SleeplessByte

Copy link
Copy Markdown
Member

It's in #838 (comment) . Basically explain the JS implementation (tree) yadayada

@SleeplessByte

Copy link
Copy Markdown
Member

/format

@github-actions

Copy link
Copy Markdown
Contributor

The "Format code" action has started running.

@github-actions

Copy link
Copy Markdown
Contributor

The "Format code" action has finished running.

@github-actions

Copy link
Copy Markdown
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests for Zipper are far from sufficient

2 participants