Skip to content

Fix unit tests and example solution for Prime Factors exercise #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tejasbubane merged 1 commit into from
Sep 10, 2018
Merged

Fix unit tests and example solution for Prime Factors exercise #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions exercises/prime-factors/example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
class PrimeFactors {
for(num) {
const factors = [];
let currentFactor = 2;
export const primeFactors = (num) => {
const factors = [];
let currentFactor = 2;

while (num !== 1) {
if (num % currentFactor === 0) {
factors.push(currentFactor);
num /= currentFactor;
currentFactor = 2;
} else {
currentFactor++;
}
while (num !== 1) {
if (num % currentFactor === 0) {
factors.push(currentFactor);
num /= currentFactor;
currentFactor = 2;
} else {
currentFactor++;
}
return factors;
}
}

export default PrimeFactors;
return factors;
};
25 changes: 12 additions & 13 deletions exercises/prime-factors/prime-factors.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,25 @@
import PrimeFactors from './prime-factors';
const primeFactors = new PrimeFactors();
import { primeFactors } from './prime-factors';

describe('primeFactors', () => {
test('returns an empty array for 1', () => expect(primeFactors.for(1)).toEqual([]));
test('returns an empty array for 1', () => expect(primeFactors(1)).toEqual([]));

xtest('factors 2', () => expect(primeFactors.for(2)).toEqual([2]));
xtest('factors 2', () => expect(primeFactors(2)).toEqual([2]));

xtest('factors 3', () => expect(primeFactors.for(3)).toEqual([3]));
xtest('factors 3', () => expect(primeFactors(3)).toEqual([3]));

xtest('factors 4', () => expect(primeFactors.for(4)).toEqual([2, 2]));
xtest('factors 4', () => expect(primeFactors(4)).toEqual([2, 2]));

xtest('factors 6', () => expect(primeFactors.for(6)).toEqual([2, 3]));
xtest('factors 6', () => expect(primeFactors(6)).toEqual([2, 3]));

xtest('factors 8', () => expect(primeFactors.for(8)).toEqual([2, 2, 2]));
xtest('factors 8', () => expect(primeFactors(8)).toEqual([2, 2, 2]));

xtest('factors 9', () => expect(primeFactors.for(9)).toEqual([3, 3]));
xtest('factors 9', () => expect(primeFactors(9)).toEqual([3, 3]));

xtest('factors 27', () => expect(primeFactors.for(27)).toEqual([3, 3, 3]));
xtest('factors 27', () => expect(primeFactors(27)).toEqual([3, 3, 3]));

xtest('factors 625', () => expect(primeFactors.for(625)).toEqual([5, 5, 5, 5]));
xtest('factors 625', () => expect(primeFactors(625)).toEqual([5, 5, 5, 5]));

xtest('factors 901255', () => expect(primeFactors.for(901255)).toEqual([5, 17, 23, 461]));
xtest('factors 901255', () => expect(primeFactors(901255)).toEqual([5, 17, 23, 461]));

xtest('factors 93819012551', () => expect(primeFactors.for(93819012551)).toEqual([11, 9539, 894119]));
xtest('factors 93819012551', () => expect(primeFactors(93819012551)).toEqual([11, 9539, 894119]));
});