Skip to content

Fix unit tests for Gigasecond exercise #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tejasbubane merged 1 commit into from
Sep 2, 2018
Merged

Fix unit tests for Gigasecond exercise #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions exercises/gigasecond/example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
const GIGASECOND_IN_MILIS = 1e9 * 1e3;

export default class Gigasecond {

constructor(dateOfBirth) {
this.dateOfBirth = dateOfBirth;
}

date() {
const birthTime = this.dateOfBirth.getTime();
return new Date(birthTime + GIGASECOND_IN_MILIS);
}

export const gigasecond = dateOfBirth => {
const birthTime = dateOfBirth.getTime();
return new Date(birthTime + GIGASECOND_IN_MILIS);
}
21 changes: 7 additions & 14 deletions exercises/gigasecond/gigasecond.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,21 @@
import Gigasecond from './gigasecond';
import { gigasecond } from './gigasecond';

describe('Gigasecond', () => {
test('tells a gigasecond anniversary since midnight', () => {
const gs = new Gigasecond(new Date(Date.UTC(2015, 8, 14)));
const gs = gigasecond(new Date(Date.UTC(2015, 8, 14)));
const expectedDate = new Date(Date.UTC(2047, 4, 23, 1, 46, 40));
expect(gs.date()).toEqual(expectedDate);
expect(gs).toEqual(expectedDate);
});

xtest('tells the anniversary is next day when you are born at night', () => {
const gs = new Gigasecond(new Date(Date.UTC(2015, 8, 14, 23, 59, 59)));
const gs = gigasecond(new Date(Date.UTC(2015, 8, 14, 23, 59, 59)));
const expectedDate = new Date(Date.UTC(2047, 4, 24, 1, 46, 39));
expect(gs.date()).toEqual(expectedDate);
expect(gs).toEqual(expectedDate);
});

xtest('even works before 1970 (beginning of Unix epoch)', () => {
const gs = new Gigasecond(new Date(Date.UTC(1959, 6, 19, 5, 13, 45)));
const gs = gigasecond(new Date(Date.UTC(1959, 6, 19, 5, 13, 45)));
const expectedDate = new Date(Date.UTC(1991, 2, 27, 7, 0, 25));
expect(gs.date()).toEqual(expectedDate);
});

xtest('make sure calling "date" doesn\'t mutate value', () => {
const gs = new Gigasecond(new Date(Date.UTC(1959, 6, 19, 5, 13, 45)));
const expectedDate = new Date(Date.UTC(1991, 2, 27, 7, 0, 25));
gs.date();
expect(gs.date()).toEqual(expectedDate);
expect(gs).toEqual(expectedDate);
});
});