Repository navigation
Fix unit tests and example for Pangram exercise - #462
Merged
Merged
Conversation
Change the unit tests for the Pangram exercise to accept a named function export instead of a default class export as per issues exercism#274 and exercism#436: - Change default class import `Pangram` to named function import `{ isPangram }`. - Remove unnecessary `const pangram = new Pangram(...` lines. - Change `pangram.isPangram(...` calls to `isPangram(...`. - Redesign example.js file to export a single named function.
tejasbubane
approved these changes
Sep 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the unit tests for the Pangram exercise to accept a named function export instead of a default class export as per issues #274 and #436:
Pangramto named function import{ isPangram }.const pangram = new Pangram(...lines.pangram.isPangram(...calls toisPangram(....