Skip to content

grade-school: Force const on roster() and grade() #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcuru merged 2 commits into from
Sep 14, 2019
Merged

grade-school: Force const on roster() and grade() #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4f5820
grade-school: Force const on roster() and grade()
siebenschlaefer Jun 2, 2019
7349a40
Adding value initialization.
arcuru Sep 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exercises/grade-school/grade_school_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ using namespace std;

TEST_CASE("a_new_school_has_an_empty_roster")
{
grade_school::school school_;
const grade_school::school school_{};
REQUIRE(school_.roster().empty());
}

Expand Down Expand Up @@ -62,7 +62,7 @@ TEST_CASE("grade_returns_the_students_in_that_grade_in_alphabetical_order")

TEST_CASE("grade_returns_an_empty_array_if_there_are_no_students_in_that_grade")
{
grade_school::school school_;
const grade_school::school school_{};
const auto actual = school_.grade(1);

REQUIRE(actual.empty());
Expand All @@ -88,7 +88,7 @@ TEST_CASE("the_student_names_in_each_grade_in_the_roster_are_sorted")

TEST_CASE("checking_a_grade_should_not_change_the_roster")
{
grade_school::school school_;
const grade_school::school school_{};
school_.grade(1);
REQUIRE(school_.roster().empty());
}
Expand Down