Skip to content

Maintain a blacklist of malicious peers  #386

Closed
#610
Closed
Maintain a blacklist of malicious peers #386
#610
Assignees
tzdybalrandomshinichi

Description

@jbowen93
jbowen93
opened on May 3, 2022

Optimint nodes should maintain a blacklist of peers that they have determined are acting malicious. Nodes should sever their peering connections with malicious nodes and refuse to rebroadcast any messages they receive from these nodes.

We should consider if there is value in having a set of "blacklist seed nodes" which maintain a blacklist they can share with new nodes joining the p2p network.

Subtasks:

  • Use libp2p.ConnectionGater to limit connections
  • Implement datastore.Datastore interface
  • Add configuration option/param to block peer/IP
  • Make it possible to unblock blacklisted peer/IP

Activity

  1. jbowen93
    added
    C: Astria
    on May 3, 2022
  2. adlerjohn
    added this to Celestia Nodeon May 3, 2022
  3. adlerjohn
    moved this to TODO in Celestia Nodeon May 3, 2022
  4. tzdybal
    assigned
    Manav-Aggarwal
    on Oct 18, 2022

  5. tzdybal commented on Oct 18, 2022

    @tzdybal
    tzdybal
    on Oct 18, 2022
    Contributor

    To actually implement blacklisting we should use ConnectionGater interface. Probably, default implementation will be sufficient.

    Gater has to be passed as an option here: https://github.com/celestiaorg/rollmint/blob/cc0a2950ea752b8905fb35062069a951c99ef115/p2p/client.go#L230

  6. Manav-Aggarwal
    removed their assignment
    on Oct 27, 2022

  7. randomshinichi commented on Oct 28, 2022

    @randomshinichi
    randomshinichi
    on Oct 28, 2022
    Contributor

    Looks like an issue with meat, I'll take it on

  8. tzdybal
    assigned
    randomshinichi
    on Oct 30, 2022
  9. tzdybal
    moved this from TODO to In Progress in Celestia Nodeon Nov 15, 2022
  10. tzdybal
    added this to Execution Environments and removed this from Celestia Nodeon Nov 16, 2022
  11. tzdybal
    moved this to TODO in Execution Environmentson Nov 17, 2022
  12. tzdybal
    closed this as completedin #610on Jan 17, 2023
  13. tzdybal
    added a commit that references this issue on Jan 17, 2023

    Connection Gater (#610)

    e5ec6a8
  14. github-project-automation
    moved this from TODO to Done in Execution Environmentson Jan 17, 2023
  15. tzdybal
    self-assigned this
    on Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions