You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add back timestamp and app hash validation in execValidate #2250
We removed the timestamp and app hash validation in the execValidate method in manager for now due to problems with the evm execution layer.
I saw the timestamp issue when running rollkit with evm execution so need to investigate.
For app hash validation, evm execution uses immediate execution while execValidate is called while assuming deferred execution, so rollkit might need to be aware whether it's immediate or deferred execution to call execValidate correctly or modify execValidate itself to make it aware.
Looks like needing to care about immediate/delayed execution here isn't necessary to add back timestamp and app hash validation which I've added back here: #2433.
Activity
tac0turtle commentedon Jun 16, 2025
can we leave this check the execution layer? we would extend the execution api and then that way we dont have to worry about it in rollkit itself?
feat: execution verification (#2377)
Manav-Aggarwal commentedon Jul 2, 2025
Looks like needing to care about immediate/delayed execution here isn't necessary to add back timestamp and app hash validation which I've added back here: #2433.