Skip to content

Create ADR describing interacting with DALC implementations #142

Closed

Description

@tzdybal
No description provided.

Activity

  1. tzdybal commented on Oct 21, 2021

    @tzdybal
    ContributorAuthor

    Call summary (by @evan-forbes):

    We will expand the approach to keep the DALC behind a grpc server. One of the main reasons for this is that we can’t have two libp2p hosts in the same process, and ideally not even on the same machine. Also, optimint cannot import celestia-node, because celestia-node requires dependencies for celestia-core and celestia-app, while optimint must only import tendermint. In the future, this aspect might change as the requirements for what exactly can and can’t go in each repo are still in flux.

    Short Term

    • completely removing any dependencies on celestia-app
    • progress with the grpc mocked DALC PR
    • Nothing changes for celestia-node

    Medium Term

    • write a DALC grpc adapter for celestia-node once celestia-node has DAS functionality. The current plan is to keep this code in a separate repo. It might end up being a good idea to include it in celestia-app or celestia-node, but that is tbd

    Long Term

    • edit Unless we figure out a way to safely use libp2p hosts and create a DAS client that doesn't import celestia-core in the same process/machine, we will continue to delegate all data availability processes to this DALC server/middleware
  2. liamsi commented on Oct 22, 2021

    @liamsi
    Contributor

    Unless we figure out a way to safely use libp2p hosts in the same process/machine

    Q: Wouldn't that just mean having a different identity key and using a different port? How would that not be safe?

  3. evan-forbes commented on Oct 22, 2021

    @evan-forbes
    Contributor

    cc @Wondertan

    Good question, I think there was mention of some global vars that libp2p relies on.

    edit: added the condition that DAS client would also have to not import celestia-node as to avoid importing celestia-core

  4. Manav-Aggarwal commented on Jun 27, 2024

    @Manav-Aggarwal
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions