Repository navigation
CI: report-only Si5351 regression tests - #111
Merged
Merged
Conversation
Harness from Test Lab, vendored under tests/regression. Runs on pull requests; not a required check. Approved by Jason Milldrum 2026-10-30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Test Lab's Si5351 regression harness under
tests/regressionand a GitHub Actions workflow (.github/workflows/regression.yml) that runs it on every pull request and on pushes to non-master branches.Report-only. This is not a required check and never gates merges. No branch protection changes. Existing
main.yml(lint/compile) andsize-deltas.ymlare untouched. No license changes.Approved by Jason Milldrum (NT7S) on 2026-10-30.
What it runs
tests/regression/run_v231_checks.sh --src $GITHUB_WORKSPACEbuildssrc/si5351.cppnatively with g++ against host Arduino/Wire stubs, then checks:--require-fixedon the v2.3.1 branch to make them hard failures.A summary is written to the job summary, and logs are uploaded as an artifact.
Expected status on master
Green: PASS 7, XFAIL 25 (v2.3.1 bugs), INFO 3, 0 FAIL. Latest run on the PR: https://github.com/etherkit/Si5351Arduino/actions/runs/41141012656 (green, same counts).
Harness by Test Lab, vendored unchanged from its working copy (
ci/, without generatedruns/).Notes
tests/regression/sketches/Ctor106/Ctor106.inois stored asCtor106.ino.txt, because arduino-lint inmain.ymlrejects sketches outsideexamples/.run_v231_checks.shcopies it back to.inowhen it builds with--cores. That's the only change from Test Lab's copy.compilejobs fail on this PR, and that isn't caused by this change.ubuntu-latestis now Ubuntu 26.04, andarduino/compile-sketches@v1asks for Python 3.12.4, which isn't available for 26.04. Lint passes.main.ymlis left untouched as asked, so this needs its own fix, such as pinningruns-on: ubuntu-24.04.