Repository navigation
Close proxy dispatch classes on Client.close() - #826
Merged
Merged
Conversation
Merged
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
…lled. (#826) * Raise a neater RuntimeError when the correct async deps are not installed * Run scripts/unasync * Update CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #824
Actually it would be better for us to gracefully handle the case where one or more
close()calls error, and still end up calling all of them, only raising an exception at the end, however there's no reason that we can treat that as an incremental improvement on top of this.