Repository navigation
Add docs on request instances to Requests compatibility guide - #823
Merged
Merged
Conversation
* Add prepare_request equivalent of httpx to compatibility document * Add difference b/w httpx.Request and requests.Request arguments to compatibility document
Contributor
Author
|
Hello @florimondmanca , I have tried to address the issues #794 and #795 with adding the documentation in this PR. |
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Thanks a ton! I left a few copy suggestions, but this is a nice step forward.
* Remove Request arguments section * Add new section Request instantiation with necessary info
florimondmanca
changed the title
florimondmanca
changed the title
Contributor
|
Hi @lonewolf3739, since #836 is now merged seems like we should be able to update this PR and get it over the line? |
Commit the suggested changes Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Contributor
Author
|
Hi, @florimondmanca I have updated the docs. |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
…tionNotAvailable (#823) * add failing tests * fix pooltimeout * Revert "add failing tests" This reverts commit cacc248c1fc7f968c5e40067fba615df1c056e2d. * mark `if timeout < 0` as not covered, since the test is reverted * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prepare_request equivalent of httpx to compatibility document
Add difference b/w httpx.Request and requests.Request arguments to compatibility document
Fixes #795, fixes #794