Skip to content

Drop Host header for HTTP/2 - #82

Merged
lovelydinosaur merged 1 commit into
masterfrom
drop-host-header-for-http2
May 28, 2019
Merged

lovelydinosaur merged 1 commit into
masterfrom
drop-host-header-for-http2

Conversation

@lovelydinosaur

@lovelydinosaur lovelydinosaur commented May 28, 2019 •

Copy link
Copy Markdown
Member

Don't setup a 'Host' header automatically under prepare_request.
Only send the header with HTTP/1.1

Closes #80

@lovelydinosaur

Copy link
Copy Markdown
Member Author

Some servers appear to treat including the Host header with HTTP/2 requests to be a protocol violation. (Didn't appear to be on my spec reading, but whatevs.)

@lovelydinosaur
lovelydinosaur merged commit 76bc6c6 into master May 28, 2019
@lovelydinosaur
lovelydinosaur deleted the drop-host-header-for-http2 branch May 28, 2019 13:40
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

HTTP/2 connection implementation is currently flaky.

1 participant