Skip to content

Fix httpx.Proxy(..., mode="FORWARD_ONLY") configuration. - #788

Merged
lovelydinosaur merged 1 commit into
encode:masterfrom
bandoche:patch-1
Jan 22, 2020
Merged

lovelydinosaur merged 1 commit into
encode:masterfrom
bandoche:patch-1

Conversation

@bandoche

Copy link
Copy Markdown
Contributor

FORWARD_ONLY seems correct

assert proxy_mode in ("DEFAULT", "FORWARD_ONLY", "TUNNEL_ONLY")

and
if mode not in ("DEFAULT", "CONNECT_ONLY", "TUNNEL_ONLY"):

seems different.

@lovelydinosaur lovelydinosaur added the bug Something isn't working label Jan 22, 2020
@lovelydinosaur lovelydinosaur changed the title Fix ProxyMode for code in dispatch/proxy_http Fix httpx.Proxy(..., mode="FORWARD_ONLY") configuration. Jan 22, 2020
@lovelydinosaur

Copy link
Copy Markdown
Member

Good catch, thanks!

@lovelydinosaur
lovelydinosaur merged commit b1e99a5 into encode:master Jan 22, 2020
@lovelydinosaur lovelydinosaur mentioned this pull request Mar 5, 2020
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Bumps [coverage[toml]](https://github.com/nedbat/coveragepy) from 7.2.7 to 7.3.0.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](coveragepy/coveragepy@7.2.7...7.3.0)

---
updated-dependencies:
- dependency-name: coverage[toml]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants