Repository navigation
Detect credentials in proxy URLs and create Proxy-authorization header - #780
Merged
yeraydiazdiaz merged 3 commits intoJan 20, 2020
Merged
Conversation
yeraydiazdiaz
changed the title
lovelydinosaur
requested changes
Jan 20, 2020
lovelydinosaur
left a comment
lovelydinosaur
left a comment
Member
There was a problem hiding this comment.
Fantastic stuff! One very minor implementation suggestion.
Contributor
Author
|
Awesome, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #779
Use the same logic from
proxy_httpin theProxyconfig, e.g. detects if credentials are present in the proxy URL and adds the authorization header accordingly. Also remove the credentials for the URL.