Skip to content

Make error responses raise an HTTPError by default - #754

Closed
florimondmanca wants to merge 1 commit into
masterfrom
error-response-exceptions
Closed

florimondmanca wants to merge 1 commit into
masterfrom
error-response-exceptions

Conversation

@florimondmanca

Copy link
Copy Markdown
Contributor

Closes #752, includes both docs and implementation.

We could also introduce the raise_for_status parameter first, and then switch it to on-by-default, though I think if that's what we'd do then it makes sense to have everything in one PR.

@florimondmanca florimondmanca added user-experience Ensuring that users have a good experience using the library api change PRs that contain breaking public API changes labels Jan 11, 2020
@florimondmanca
florimondmanca requested a review from a team January 11, 2020 19:18
@florimondmanca

Copy link
Copy Markdown
Contributor Author

Closing for now per #752 (comment).

@florimondmanca
florimondmanca deleted the error-response-exceptions branch January 20, 2020 22:32
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
* Move configurations to pyproject.toml, use ruff instead of flake8, autoflake and isort

* Add --fix for ruff

* Add ruff to requirements

* Add black

* Fix omit and include

* Add isort

* Add show-source option to ruff check

* Drop isort configs

Co-authored-by: Zanie <contact@zanie.dev>

* Remove autoflake from scripts/lint

---------

Co-authored-by: Zanie <contact@zanie.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change PRs that contain breaking public API changes user-experience Ensuring that users have a good experience using the library

Development

Successfully merging this pull request may close these issues.

Should error responses raise an HTTPError by default?

1 participant