Repository navigation
Unasync'ed base dispatchers - #742
Closed
florimondmanca wants to merge 2 commits into
Closed
florimondmanca wants to merge 2 commits into
florimondmanca wants to merge 2 commits into
Conversation
Contributor
Author
|
Just tried it out locally… the build works 👍 $ pip install "git+https://github.com/encode/httpx.git@unasynced-base-dispatchers"
$ python
Python 3.8.0 (default, Oct 16 2019, 18:21:21)
[Clang 11.0.0 (clang-1100.0.33.8)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import httpx
>>> r = httpx.get('https://www.google.com')
>>> httpx._sync.dispatch.base.SyncDispatcher
<class 'httpx._sync.dispatch.base.SyncDispatcher'>
>>> httpx.dispatch.base.SyncDispatcher
<class 'httpx._sync.dispatch.base.SyncDispatcher'>
>>> |
florimondmanca
commented
Jan 8, 2020
| pytest-cov | ||
| trio | ||
| trustme | ||
| unasync==0.4.* |
Contributor
Author
There was a problem hiding this comment.
That's a bit funny, but listing unasync in the build-system.requires entry doesn't actually install it in a way that's available to the Python interpreter. I don't know when/where those dependencies are installed exactly — probably managed by pip in an opaque location…?
Contributor
Author
|
Ah yes, the build will fail until python-trio/unasync@2c2c9b7 gets released. 😄 (I had a patched version of |
Contributor
Author
|
Closing, we can revisit if/when moving forward on this in |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.3.1 to 7.4.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.3.1...7.4.0) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #722
First smoll step towards unasync'ing HTTPX…: unasync
AsyncDispatcherintoSyncDispatcher. Allows us to setup the tooling and avoid impacting any public piece of API.Mostly done, but marking as a draft as this is probably only worth considering once 0.11 is out…