Repository navigation
proxies_to_dispatchers -> get_proxy_map - #733
Merged
Merged
Conversation
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
* Refactor HTTP/2 stream events * Refactor HTTP/2 stream events * Graceful handling of HTTP/2 GoAway frames * Add to CHANGELOG * Remove unneccessary getattr * Conditional fix * Conditional fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch
proxies_to_dispatchestoget_proxy_map.This style means that we end up with a map of
{key: Proxy()}, which is sync/async compatible,so
get_proxy_mapis shared across both implementations, whereproxies_to_dispatcherscould not be.Should mean that addressing any thing else demo'ed by #716 can be a single fairly clean PR for review.