Repository navigation
Public Auth API - #732
Merged
Merged
Public Auth API#732
Conversation
Closed
Contributor
|
Cc'ing @lepture relative to authlib/authlib#178 (comment) — from the docs proposed here, would this fit the use case for |
lovelydinosaur
added
enhancement
florimondmanca
approved these changes
Jan 7, 2020
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Yes for me! Just a small nit. I'm really happy with how the auth API turned out. 😄
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Member
Author
I think you made a great call on the generator approach. 👍 It's also kinda nice that we've got a |
|
yes, that would work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #731
Starting this PR with the proposed documentation. Implementation will require:
.auth_flow.Request.aread()method andRequest.contentproperty..requires_request_bodyfunctionality on auth flows.httpx.Authas public API.AuthFlowin favor of explicit type, in order to help guide users away from importing bits ofhttpxthat are outside public API.