Repository navigation
Proposed 0.11 docs - #727
Merged
Merged
Conversation
florimondmanca
self-requested a review
January 7, 2020 12:02
florimondmanca
suggested changes
Jan 7, 2020
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Left a bunch of suggestions :-)
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Contributor
|
@tomchristie Also there are three pending comments that GitHub shows under "3 more items hidden", have you seen those? |
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Member
Author
|
Thanks @florimondmanca! Nope, I'd not noticed those other suggestions. The |
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
florimondmanca
approved these changes
Jan 8, 2020
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Looks good now! 🌈
Member
Author
|
Fantastic, thanks! ✨ |
Member
Author
|
Ah, I shoulda actually held off on merging this, since it updates the repo README. |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
* Drop Python 3.7 support * Changelog * Changelog * Fix rebase * Remove unnecessary black argument, it will be inferred https://black.readthedocs.io/en/stable/change_log.html#id24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There may well be a bunch of stuff still to think over here, but this is what I've got right now...