Repository navigation
Record history of requests made during authentication - #718
Conversation
|
As a follow-up, I think we'll also want to update the wording in Redirection and History, as it currently describes the history as "a list of all any (sic) redirect responses that were followed". Technically that's true, but now the history would also list intermediate auth responses. |
lovelydinosaur
left a comment
There was a problem hiding this comment.
This is fanastic, yup!
Great work, team. ✨
| raise exc from None | ||
| else: | ||
| response.history = list(history) | ||
| await response.aread() |
There was a problem hiding this comment.
Yup, good call.
It's possible that at a later date we might want to ensure that streaming responses don't load an intermediate response bodies (in redirect or auth), but that's only a "might", and would be a seperate issue if we did choose to tackle it.
|
Merging, thanks for taking the time to look into this @gdhameeja! 💯 Added you as a co-author to bc6163c. :-) |
Fixes #669
Based on @gdhameeja's work in #686 🌟🙇
The updated tests contain:
response.historyin the digest auth case.