Repository navigation
Prep for introducing SyncClient - #713
Merged
Merged
Conversation
Member
Author
|
Can potentially split this into a smaller set of PRs if helpful. |
Closed
florimondmanca
self-requested a review
January 4, 2020 20:54
florimondmanca
approved these changes
Jan 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init_dispatch, so that we can have seperate instantiation for the sync and async cases.httpx.Proxy(...)for any fine-grained proxy configuration, rather than instantiating a dispatcher class directly. This ensures that proxy configuration looks the same in the API regardless of sync vs. async.Eg...
I've ensured that the existing proxy API is currently still supported here, so that we'd be able to bring this change in without breaking API.