Repository navigation
Move tunnel_start_tls() to HTTPConnection - #609
Merged
Merged
Conversation
Member
|
Yes! Lovely incremental refactor. |
Member
|
I guess we may also have a second half of this where we move the implementation all the way onto |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
Co-authored-by: Tom Christie <tom@tomchristie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by #496 (comment)
Removes pending HTTP version-specific usage from
HTTPProxy, in order to make it easier to disable HTTP/2 by default in the future (by lazily importingh2).I added a few extra comments in there to further clarify how and why
.tunnel_start_tls()works.