Repository navigation
Tighten up top-level API to only expose public API - #608
Merged
Merged
Conversation
florimondmanca
self-requested a review
December 6, 2019 12:51
florimondmanca
suggested changes
Dec 6, 2019
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a suggestion not to refactor/drop HTTPProxyMode here just yet?
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
* Version 0.16.1 * Add dates to releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops various private API from the top-level API.
We should recommend that our users only import the top-level
httpxpackage, rather than importing sub-modules, in order to help guide them towards public API only.Eg.
✅ Approved usage:
Refs #606