Repository navigation
Rename BaseSocketStream attributes on connections. - #601
Merged
Merged
Conversation
florimondmanca
approved these changes
Dec 5, 2019
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Nice. I like the idea of an encapsulated HTTP2Stream class as well - looking forward to see how it looks.
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
Bumps [anyio](https://github.com/agronholm/anyio) from 3.6.1 to 3.6.2. - [Release notes](https://github.com/agronholm/anyio/releases) - [Changelog](https://github.com/agronholm/anyio/blob/3.6.2/docs/versionhistory.rst) - [Commits](agronholm/anyio@3.6.1...3.6.2) --- updated-dependencies: - dependency-name: anyio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Christie <tom@tomchristie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the
BaseSocketStreamattribtues onH11ConnectionandH2Connectioninstances fromconnection.streamtoconnection.socket.I think
self.socket.write(...)is more clearly a "we're really about to do some I/O operation" thanself.stream.write(...), so I'm happy with how this looks.More importantly tho' we really really ought to have a clearer HTTP/2 implementation with an
HTTP2Streaminstance for each HTTP/2 stream. We'll want the connection class to hold a.streamsdictionary, mapping stream IDs ontoHTTP2Streaminstances.Making this isolated change here & now, because it's a tiny step in that direction.
Not a user facing change, so won't make the CHANGELOG.