Repository navigation
Better HTTP/2 defaults. - #584
Conversation
florimondmanca
left a comment
There was a problem hiding this comment.
Took a glance at the docs and found a few typos.
I like this change!
I suppose this moves us forward relative to minimal dependencies, eg we’ll now be able to not require h2 unless users want to use HTTP/2?
Ah yeah I'd forgotten about that. We can also make that switch here, yup.
And a check on the client for "if http_2 is True and h2 is not installed then error". |
I’d rather we deal with it later, this PR is quite a big chunk already. :-) |
|
Good call. |
|
Should we use I think the later is probably neater, right? |
|
Just remembered we had a "Minimal installs" issue here — #496. |
Bumps [coverage](https://github.com/nedbat/coveragepy) from 6.4.4 to 6.5.0. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](coveragepy/coveragepy@6.4.4...6.5.0) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Client(http2=True)to enableCloses #582
Still TODO:
API changes for
http_version=...tohttp_2=[True|False], so we should leave this to a 0.9 release.