Repository navigation
Add test to https server - #57
Merged
Merged
Conversation
Contributor
Author
|
In terms of test coverage, there are paths which are only hit with an appropriately signed certificate, not sure how we'd like to address that to achieve 100%. |
Member
|
How long is the cert signed for here? |
Contributor
|
For signed certificates, I would suggest using https://github.com/python-trio/trustme. We use this in urllib3 and it works well. For bonus points, generate new certs/keys dynamically in the tests, which is possible since trustme is written in Python. It avoids storing blobs in the test suite. |
Member
|
Oh nice! Great tip! |
Add `https_server` test fixture
Contributor
Author
|
Updated with |
Member
|
Great stuff. 馃槑 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
https_servertest fixture.The self-signed certificate was created using these steps.