Repository navigation
Fix race condition on stream.read - #535
Merged
Merged
Conversation
florimondmanca
added
http/2
florimondmanca
force-pushed
the
fix/concurrent-read
branch
from
November 17, 2019 11:43
f95688f to
6f98fc0
Compare
florimondmanca
requested review from
lovelydinosaur
and removed request for
a team
November 17, 2019 11:43
yeraydiazdiaz
approved these changes
Nov 21, 2019
yeraydiazdiaz
left a comment
yeraydiazdiaz
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a minor nit. Thanks! 馃専
Contributor
Author
|
Thanks for the review @yeraydiazdiaz! |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
* Remove Python 3.6 related code * Remove Python 3.6 from matrix strategy * Unpin `twine` version * Bump `black` version * Make black target version 3.7 * Unpin `wheel` dependency * Bump `mkdocs` to 1.3.0 * Unpin `mkdocs` * Downpin flake8 to 3.9.2 * Pin Jinja2 to 3.0.3 * Attempt: bump pytest-httpbin to 1.0.2 * Pin werkzeug * Add note about 3.7+ in README/docs Co-authored-by: Michael Oliver <michael@michaeloliver.dev> Co-authored-by: Florimond Manca <florimond.manca@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #527
Turns out that the bug was also present on trio, so I added a fix and test for it too.
I'm not sure that we'd also need a lock around the asyncio write operation (we already have one on trio), but no bug was reported yet and we should probably investigate that separately anyway.