Repository navigation
Allow using Client in an async environment - #513
Closed
florimondmanca wants to merge 1 commit into
Closed
florimondmanca wants to merge 1 commit into
florimondmanca wants to merge 1 commit into
Conversation
florimondmanca
requested review from
lovelydinosaur,
sethmlarson and
yeraydiazdiaz
November 7, 2019 13:30
florimondmanca
force-pushed
the
feat/asyncio-client-sync-in-async
branch
from
November 8, 2019 20:05
7d1e224 to
bf7f207
Compare
Contributor
Author
|
@encode/httpx-maintainers OK, I think I've got something that passes the tests. Basically we're checking if the event loop is running and when relevant run the coroutine in a worker thread instead. This thing is inspired by |
florimondmanca
force-pushed
the
feat/asyncio-client-sync-in-async
branch
from
November 8, 2019 21:14
bf7f207 to
b651380
Compare
Contributor
Author
|
Closing as I don't think this will make it, probably in favor of a |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
Fixes #512 Co-authored-by: Tom Christie <tom@tomchristie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #508
This is an attempt at handling the situation in which users try to use
httpx.get()orhttpx.Client()in an async environment that has a running loop (e.g. in a Jupyter notebook).I documented several potential caveats in the form of code comments.
I still need to verify this actually solves the Jupyter use case, though the tests give me hope that it does. :-)