[dobrovolsky]

related to #35

with Client() as client:
    response = client.get(..., stream=True)
response.read()  # This should raise an error.

[sethmlarson]

Thanks for opening this @dobrovolsky! :)

[florimondmanca]

Hey, sorry that we seem to have let this slip under our radar!

Overall this is a great starting point, thank you! That said, we still need to make sure connections are properly closed so that the RemoteProtocolError does not happen in the first place. I've left a comment with various hints on how this could be implemented. Please let me know if you'd like to take it on!

[florimondmanca]

I think we should not let an h11 exception bubble up to our users; we need to raise an HTTPX-specific exception here. I believe ResponseClosed is the most adequate.

This made me realize that we are not force-closing responses yet here on client exit. You can see this by turning on HTTPX_DEBUG and seeing receive_event NEED_DATA log lines because the response object is still trying to receive response data, and that is because we did not call .close() on it to send a ResponseClosed event to h11.

I guess implementing response closing on client exit involves some form of storing "pending responses" on the client. We'd add the response there in the .request() methods, remove it when the response's on_close() callback is normally called, and iterate over it in client's __exit__() or __aexit__() to close any pending responses.

Would you like to look into this?

[lovelydinosaur]

Thanks for having put a bunch of time into this.
As it happens, it's now obsoleted by our more tightly bounded stream() API, which ensures that connections can only be held open within a stream() context block.