Skip to content

Repository navigation

Drop NPN support - #314

Merged
lovelydinosaur merged 1 commit into
encode:masterfrom
dobrovolsky:drop_npn
Sep 4, 2019
Merged

Drop NPN support#314
lovelydinosaur merged 1 commit into
encode:masterfrom
dobrovolsky:drop_npn

Conversation

@dobrovolsky

@dobrovolsky dobrovolsky commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

Closes #280

@lovelydinosaur

lovelydinosaur commented Sep 4, 2019

Copy link
Copy Markdown
Member

Welcome! Nice little improvement here, thank you. 馃帀

We could drop the if ident is None: block here now, since the return "HTTP/2" if ident == "h2" else "HTTP/1.1" line would still return the right result there. However I don't think it's neccessarily a bad thing to handle the None case explicitly, so let's get this in as it currently stands.

@lovelydinosaur
lovelydinosaur merged commit cbe7616 into encode:master Sep 4, 2019
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
@lovelydinosaur
Version 0.13.2 (#314)
5e48607 
* Improve error message for specific case of RemoteProtocolError where server disconnects without sending a response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop NPN support

2 participants

@dobrovolsky @lovelydinosaur