Skip to content

Add test for origin from URL string - #312

Merged
florimondmanca merged 1 commit into
encode:masterfrom
yeraydiazdiaz:missing-test-for-origin-model
Sep 4, 2019
Merged

florimondmanca merged 1 commit into
encode:masterfrom
yeraydiazdiaz:missing-test-for-origin-model

Conversation

@yeraydiazdiaz

Copy link
Copy Markdown
Contributor

Bringing coverage back to 100%

This PR may or may not have been triggered by my OCD 😄

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call, thanks :)

@florimondmanca
florimondmanca merged commit fa74aaa into encode:master Sep 4, 2019
@lovelydinosaur

Copy link
Copy Markdown
Member

How do we want to go about turning on 100% enforcement?

@florimondmanca

Copy link
Copy Markdown
Contributor

@tomchristie I remember there were already bribes of discussion about this somewhere but I can’t remember. Should we open a dedicated issue?

@lovelydinosaur

Copy link
Copy Markdown
Member

Same here yes, but I don't recall where exactly.
Let's have an issue for it yeah.

Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants