Skip to content

test: Drop private imports from test_proxies.py - #2850

Merged
lovelydinosaur merged 1 commit into
encode:masterfrom
YDX-2147483647:refactor/proxies-private-imports
Sep 16, 2023
Merged

lovelydinosaur merged 1 commit into
encode:masterfrom
YDX-2147483647:refactor/proxies-private-imports

Conversation

@YDX-2147483647

@YDX-2147483647 YDX-2147483647 commented Sep 16, 2023 •

Copy link
Copy Markdown
Contributor

Summary

Refactor a test case that imports from private namespace, as suggested in #2492.

The original version constructs URLPatterns to compare. This PR destructs them.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. (This is a test refactor)
  • I've updated the documentation accordingly. (No code changed)

@YDX-2147483647 YDX-2147483647 changed the title Drop private imports from test_proxies.py test: Drop private imports from test_proxies.py Sep 16, 2023

@lovelydinosaur lovelydinosaur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 馃槉

@lovelydinosaur
lovelydinosaur merged commit e4241c6 into encode:master Sep 16, 2023
@YDX-2147483647
YDX-2147483647 deleted the refactor/proxies-private-imports branch September 17, 2023 02:44
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants