Skip to content

Add back in URL.raw with NamedTuple - #2481

Merged
lovelydinosaur merged 4 commits into
encode:masterfrom
developerDemetri:re-add-url-dot-raw
Dec 2, 2022
Merged

lovelydinosaur merged 4 commits into
encode:masterfrom
developerDemetri:re-add-url-dot-raw

Conversation

@developerDemetri

@developerDemetri developerDemetri commented Nov 30, 2022 •

Copy link
Copy Markdown
Contributor

Closes #2462 with a basic test, happy to add tests for more scenarios

@lovelydinosaur lovelydinosaur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'm happy with this.

We could also add a comment on the .raw() method metioning that it is due to be deprecated in a future release, but I don't mind too much either way, so wouldn't consider it a blocker.

@lovelydinosaur

Copy link
Copy Markdown
Member

Okay, let's go with this.

We'll want a new minor point release.

@lovelydinosaur
lovelydinosaur merged commit 40a0da0 into encode:master Dec 2, 2022
@developerDemetri
developerDemetri deleted the re-add-url-dot-raw branch December 14, 2022 01:49
@lovelydinosaur lovelydinosaur mentioned this pull request Dec 20, 2022
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
* add back in URL.raw with NamedTuple

* Update _urls.py

* Update _urls.py

Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Breaking drop of URL.raw in patch release 0.23.1

2 participants