Repository navigation
Typing: always fill in generic type parameters - #2468
Merged
Merged
Conversation
Being explicit about the parameters helps find bugs and makes the library easier to use for users. - Tell mypy to disallow generics without parameter values - Give all generic types parameters values
Closed
adriangb
force-pushed
the
fill-in-generics
branch
from
November 29, 2022 07:17
ec97282 to
3f1f415
Compare
lovelydinosaur
approved these changes
Nov 29, 2022
lovelydinosaur
left a comment
lovelydinosaur
left a comment
Member
There was a problem hiding this comment.
Mixed feelings about bits where the typing becomes super verbose, but... sure. 🤷♂️
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
* Typing: always fill in generic type parameters Being explicit about the parameters helps find bugs and makes the library easier to use for users. - Tell mypy to disallow generics without parameter values - Give all generic types parameters values * fix things that aren't coming in from other commits * lint Co-authored-by: Martijn Pieters <mj@zopatista.com> Co-authored-by: Tom Christie <tom@tomchristie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being explicit about the parameters helps find bugs and makes the library easier to use for users.