Skip to content

Remove typeshed iscoroutine workaround - #2466

Merged
adriangb merged 1 commit into
encode:masterfrom
adriangb:remove-iscoro-workaround
Nov 29, 2022
Merged

adriangb merged 1 commit into
encode:masterfrom
adriangb:remove-iscoro-workaround

Conversation

@adriangb

@adriangb adriangb commented Nov 29, 2022 •

Copy link
Copy Markdown
Contributor

This was resolved in typeshed and newer mypy versions have inherited the fix.

pyright reports:
after.txt
before.txt

This was resolved in typeshed and newer mypy versions have inherited the fix.
@adriangb
adriangb requested a review from a team November 29, 2022 06:45
@adriangb adriangb mentioned this pull request Nov 29, 2022

@abersheeran abersheeran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adriangb
adriangb merged commit 75a13a1 into encode:master Nov 29, 2022
@adriangb
adriangb deleted the remove-iscoro-workaround branch November 29, 2022 08:45
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
This was resolved in typeshed and newer mypy versions have inherited the fix.

Co-authored-by: Martijn Pieters <mj@zopatista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants