Repository navigation
Add logging to h2 connection - #240
yeraydiazdiaz wants to merge 1 commit into
Conversation
|
I was thinking we'd have DEBUG for everything besides data transfer and then set TRACE for readers / writers with raw data going in and out. What do you think about that? |
|
Sorry, I'm not sure what you mean with setting TRACE of readers and writers. |
|
Basically the raw data getting sent/received over streams should be I had an example logging setup on a different dispatcher that I'd like everyone to look at and see what they think. |
|
That's what I thought you meant but I there's no |
|
@yeraydiazdiaz You're right, although it has been suggested before. Logging levels are extensible though — example inspired from this comment: # logging.py
import logging
TRACE = 5
logging.addLevelName(TRACE, 'TRACE')Then you could write: from ..logging import TRACE
logger.log(TRACE, "Stream [%d] - Received response events: %r", stream_id, data)Is this the kind of setup you were thinking about, @sethmlarson? |
|
Going to close this in favor of #277 |
* Fix #240 for sync requests * - Fix #240 for async requests - Added comments to explain why we use the Host header in http/2 * Blackify async code * Manually blackify sync code * Apply suggestions from code review Co-authored-by: Florimond Manca <florimond.manca@gmail.com> * Autogenerated sync code Co-authored-by: cdeler <serj.krotov@gmail.com> Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
Also bump h2 version to
>=3.1.1.