Skip to content

Add fake setup.py - #2351

Merged
Kludex merged 7 commits into
masterfrom
fix-used-by-github
Sep 1, 2022
Merged

Kludex merged 7 commits into
masterfrom
fix-used-by-github

Conversation

@Kludex

@Kludex Kludex commented Aug 26, 2022 •

Copy link
Copy Markdown
Contributor

This is quite sad.

@michaeloliverx brought this to our attention on: 45b7cfa#commitcomment-82042745.

The Used by section on the project's profile disappeared after we removed the setup.py. We can either accept this PR or revert #2334, to have it back,

I'll let you folks decide @florimondmanca @tomchristie 🙏

I'll update the Starlette and Uvicorn according to what is decided here.

Closes #2352

@michaeloliverx

michaeloliverx commented Aug 26, 2022 •

Copy link
Copy Markdown
Contributor

This is the same solution as urllib3 has taken. You can read a bit more about it at https://sethmlarson.dev/blog/preparing-for-the-wave-of-open-source-funding#dependency-chain-metadata.

Edit:

Probably good to link the underlying problem. https://github.com/orgs/community/discussions/6456

@Kludex

Kludex commented Aug 26, 2022

Copy link
Copy Markdown
Contributor Author

@florimondmanca

Copy link
Copy Markdown
Contributor

That’s a raging GitHub limitation. I’d be okay with this PR; happier to use newest standards than stick to oldest because GH is lagging behind. The sad part is we’d have to do this and duplicate dependency declaration every project. So I’m on the fence…

@Kludex

Kludex commented Aug 26, 2022

Copy link
Copy Markdown
Contributor Author

How we decide here?

@Kludex

Kludex commented Aug 28, 2022

Copy link
Copy Markdown
Contributor Author

I've created #2352 as an alternative to this PR.

@lovelydinosaur

lovelydinosaur commented Aug 30, 2022 •

Copy link
Copy Markdown
Member

"Flask does this" is a pretty good argument. 😅

The sad part is we’d have to do this and duplicate dependency declaration every project. So I’m on the fence…

Indeed. I'm not wild about it either, but the pallets team have this on all their repos. Probably an okay solution for now.

Comment thread setup.py
Comment thread setup.py
@Kludex

Kludex commented Aug 31, 2022

Copy link
Copy Markdown
Contributor Author

"Flask does this" is a pretty good argument. 😅

The sad part is we’d have to do this and duplicate dependency declaration every project. So I’m on the fence…

Indeed. I'm not wild about it either, but the pallets team have this on all their repos. Probably an okay solution for now.

Since that's the case. Shall we choose this PR?

@Kludex
Kludex requested a review from a team August 31, 2022 05:46
Comment thread setup.py
@Kludex

Kludex commented Sep 1, 2022 •

Copy link
Copy Markdown
Contributor Author

I'll merge this tonight if no objections are made. 🙏

Thanks @michaeloliverx 🙏

@Kludex
Kludex merged commit 9f79b5c into master Sep 1, 2022
@Kludex
Kludex deleted the fix-used-by-github branch September 1, 2022 16:13
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants