[Kludex]

This was brought on Kludex/starlette#1359.

setuptools released 0.61.0 yesterday, and brought to light the PEP-621 which makes this PR possible. Most of the PR was inspired on this page: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

Notes:

• I'll continue later on. I need to check if everything is included on the metadata files.

How to test?

• ./scripts/build to see that wheel and tar.gz are generated
• python -m pip install -e . for editable installs

[Kludex]

Oh... setuptools doesn't support Python 3.6 anymore.

[johtso]

Discussion on dropping 3.6 support #2136

[florimondmanca]

What do we think about this bit at the top of the setuptools docs page…?

Note
New in 61.0.0 (experimental)

Warning
Support for declaring project metadata or configuring setuptools via pyproject.toml files is still experimental and might change (or be removed) in future releases.

Presumably the idea if we go with this, we'd switch all Encode projects over as well eventually. Is now a good time? Also, what does this get us compared to the current setup.py configuration?

[Kludex]

Is now a good time?

Maybe not. Let's wait for others to test this first 😅 👍

Also, what does this get us compared to the current setup.py configuration?

One less file (setup.py), and compliance with the mentioned PEP.

[florimondmanca]

For another point of comparison, I played with pyproject.toml-based packaging as well and here's what I came up with: https://github.com/florimondmanca/asgi-htmx/blob/master/pyproject.toml

[Kludex]

Thanks for the review @florimondmanca 🙇

I've updated the PR, sync with the changes that happened on setup.py, and I've added the setup.py back.

[florimondmanca]

Personally happy with this. Still happy to read other people's opinion.

My last question would be -- have we checked py.typed is present in the resulting sdist? (If not, releasing would break type hints.)

[Kludex]

It adds correctly the py.typed.

I've added the content-type on the readme and bumped twine, as I was having a warning.

[Kludex]

Let's wait for @tomchristie 's opinion here?

[jhominal]

I think we should add a minimal version of setuptools as a build requirement to ensure that a compatible version of setuptools is installed.

Suggested change

	requires = ["setuptools", "setuptools-scm"]
	requires = ["setuptools>=61", "setuptools-scm"]

[adriangb]

Agreed

[Kludex]

• Close this in favor of Update package metadata #2334