Repository navigation
added trust_env attribute on the client instance - #187
Conversation
| trust_env: bool = None, | ||
| ) -> Response: | ||
| with Client() as client: | ||
| with Client(trust_env=trust_env) as client: |
There was a problem hiding this comment.
I'd suggest passing trust_env in the request call here, instead. That'd feel more obvious to me.
| cert: CertTypes = None, | ||
| verify: VerifyTypes = None, | ||
| timeout: TimeoutTypes = None, | ||
| trust_env: bool = True, |
There was a problem hiding this comment.
We don't want to get rid of trust_env here - we just want to change the behavior so that if trust_env == None then the client default is used, but if trust_env in (True, False) then the explicitly requested behaviour is used.
c197449 to
3854125
Compare
|
Sorry, I thought you want to move |
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Code looks good, can we get one test case that verifies that setting client.request(..., trust_env=X) overrides client.trust_env?
Could you review again? I added a test that contains |
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Added a tiny bit to your test case. If CI passes we're good to go!
|
Thanks @cansarigol! :D |
|
You're welcome |
3 participants
Closes #185