Skip to content

Removed deprecated TLS versions - #155

Merged
sethmlarson merged 1 commit into
encode:masterfrom
halbow:Issue-127-TLS-default-config
Jul 27, 2019
Merged

sethmlarson merged 1 commit into
encode:masterfrom
halbow:Issue-127-TLS-default-config

Conversation

@halbow

@halbow halbow commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

So I just added the two deprecated version to the SSL context, As we support python 3.6 this should be good but this way of building the sslContext seems to be deprecated in 3.7

https://docs.python.org/3/library/ssl.html#ssl.OP_NO_TLSv1
https://docs.python.org/3/library/ssl.html#ssl.SSLContext.minimum_version

@sethmlarson

Copy link
Copy Markdown
Contributor

We'll have to look at using the new minimum_version interface. We can accomplish that in a separate PR as it'll take additional checks to make sure we get it right (since it's only available for Python 3.7+ and OpenSSL 1.1.0g+)

@sethmlarson

Copy link
Copy Markdown
Contributor

Closes #127.

@sethmlarson
sethmlarson merged commit f974ebd into encode:master Jul 27, 2019
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
…ool and SyncConnectionPool) (#155) (#160)

* Added new tests for max_keepalive_connections param (AsyncConnectionPool and SyncConnectionPool) (#155)

* Added type annotations to test_max_keepalive_connections_handled_correctly in sync_tests

* Added type annotations to test_max_keepalive_connections_handled_correctly in async_tests

Co-authored-by: Joe <nigelchiang@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants