Repository navigation
Check disconnections on connection reacquiry - #145
Merged
lovelydinosaur merged 8 commits intoJul 25, 2019
Merged
Conversation
Raise ConnectionClosedByRemote and handle on `send`
Member
Author
|
I've pulled in a last little bit of extra work on top of this in #145 which I think is now good to go. One particularly interesting point from @njsmith, here #143 (comment)
Okay, that's an interesting case. 馃槕 I'd suggest we start by getting this change in as it stands. We can the confirm if we need to finesse the specific |
Contributor
|
Should we open a separate issue to handle the 408 case? |
Member
Author
|
Yeah, defo. On it. |
Member
Author
|
Released as 0.6.8 |
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for connection aliveness on re-acquiry from connection pool.
Superseeds #143
Great work on this @yeraydiazdiaz! There was a last little bit of extra cleanup on the connection pool handling that we can do now, which it made sense for me to pick up. I think we're good to go on this one now.