Skip to content

Allow string comparison for URL().__eq__ - #139

Merged
lovelydinosaur merged 1 commit into
encode:masterfrom
StephenBrown2:make_url_str_comp
Jul 24, 2019
Merged

lovelydinosaur merged 1 commit into
encode:masterfrom
StephenBrown2:make_url_str_comp

Conversation

@StephenBrown2

Copy link
Copy Markdown
Contributor

Resolves #113

This turned out to be super easy, as casting a str to a str is idempotent, so adding str to the isinstance check allows it to pass equality checks with strs.

@lovelydinosaur

Copy link
Copy Markdown
Member

Great, yup! 馃憤

@lovelydinosaur
lovelydinosaur merged commit 8db36ed into encode:master Jul 24, 2019
@StephenBrown2
StephenBrown2 deleted the make_url_str_comp branch July 27, 2019 19:59
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
* Add Unix Domain Socket support

* Update tests

* Add uvicorn dep

* Added newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

API design question - Response.url

2 participants