Repository navigation
Edited documentation about proxy-envs usage (#404) - #1257
Merged
Merged
Conversation
cdeler
force-pushed
the
edit-doc-about-proxy-envs
branch
from
September 4, 2020 12:30
495e951 to
b2b9ff9
Compare
Contributor
|
Hello @cdeler! For traceability and reviewing purposes, could you add a PR description to clarify what this PR intends to do and what the motivation/context is? Makes it easier to know if anything is missing or could be done differently. Thanks! |
Contributor
Author
|
Thank you @florimondmanca I updated the pr description, sorry that I missed that |
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Great start! Left a few comments :-)
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
# Conflicts: # docs/environment_variables.md
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #404 I found that proxies parameters might be commented better
I added NO_PROXY to the docs, also I added a couple of examples (which describes setting proxy using envs)
Also I added two links to cURL and requests, which use the same vars to configure proxy