Repository navigation
Add Client.timeout property. - #1135
Merged
lovelydinosaur merged 1 commit intoAug 6, 2020
Merged
lovelydinosaur merged 1 commit into
lovelydinosaur merged 1 commit into
Conversation
Member
|
Ah, thanks good stuff.
Perhaps have this PR but just tackling the timeouts, and we can think about auth seperately. |
cdeler
force-pushed
the
make_base_client_auth_and_timeout_accesible_through_getter_and_setter
branch
2 times, most recently
from
August 6, 2020 09:57
6465a29 to
258bc70
Compare
Contributor
Author
yes, I'll re-edit the PR |
cdeler
force-pushed
the
make_base_client_auth_and_timeout_accesible_through_getter_and_setter
branch
from
August 6, 2020 10:05
258bc70 to
5191dc5
Compare
cdeler
force-pushed
the
make_base_client_auth_and_timeout_accesible_through_getter_and_setter
branch
from
August 6, 2020 10:31
5191dc5 to
de8652e
Compare
lovelydinosaur
changed the title
Client.timeout property.
lovelydinosaur
approved these changes
Aug 6, 2020
lovelydinosaur
left a comment
lovelydinosaur
left a comment
Member
There was a problem hiding this comment.
Fantastic, yup - lovely little change.
cdeler
deleted the
make_base_client_auth_and_timeout_accesible_through_getter_and_setter
branch
September 9, 2020 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is for #1066