Skip to content

Repository navigation

Drop extraneous proxy argument on URLLib3Transport. #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 4 commits into from
Jul 26, 2020
Merged

Drop extraneous proxy argument on URLLib3Transport. #1090

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99b8df9
Update urllib3.py
lovelydinosaur Jul 25, 2020
faac832
Update urllib3.py
lovelydinosaur Jul 25, 2020
a38e673
Merge branch 'master' into tomchristie-patch-1
lovelydinosaur Jul 26, 2020
687dfba
Merge branch 'master' into tomchristie-patch-1
lovelydinosaur Jul 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions httpx/_transports/urllib3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import httpcore

from .._config import Proxy, SSLConfig
from .._config import SSLConfig
from .._content_streams import ByteStream, IteratorStream
from .._exceptions import NetworkError, map_exceptions
from .._types import CertTypes, VerifyTypes
Expand All @@ -19,7 +19,6 @@ class URLLib3Transport(httpcore.SyncHTTPTransport):
def __init__(
self,
*,
proxy: Proxy = None,
verify: VerifyTypes = True,
cert: CertTypes = None,
trust_env: bool = None,
Expand Down