Repository navigation
Add connections - #1
Merged
Merged
Conversation
1 task
blitzy Bot
referenced
this pull request
in blitzy-research/httpx
Jul 16, 2026
…RITICAL QA findings) Two client store-preservation paths flattened a CookieStore into the legacy Cookies/CookieJar machinery, which cannot ingest a CookieStore and crashed with "AttributeError: 'str' object has no attribute 'domain'". Finding #1 (_merge_cookies): per-request cookies=CookieStore on a legacy-Cookies client crashed (or silently flattened). The merge now targets a CookieStore when EITHER the client store or the per-request argument is a CookieStore, preserving its deterministic RFC 6265/6265bis semantics. Finding #2 (_build_redirect_request): a CookieStore-backed Client/AsyncClient crashed on any redirect once the store held a cookie. The redirect now preserves the CookieStore instance instead of wrapping it in Cookies(...), mirroring the __init__/setter/merge preservation pattern. Both fixes are confined to httpx/_client.py; the Cookies class, _models.py, and _cookiestore.py are unchanged (strict additivity / backward compatibility). Adds regression tests in tests/client/test_cookies.py covering per-request CookieStore on a legacy client, client+per-request merge, CookieStore-backed redirect (sync + async), and host-only no-leak across a cross-host redirect. httpx/_client.py returns to 100% line coverage.
CodeGuardian Review — PR #1Status: Completed (3/4 agents succeeded, 1 could not run) Summary
Findings🟡 Medium
⚪ Low
Agent Status
Auto-Fix Available1 finding(s) have auto-generated fixes (test drafts, docstrings). No code is pushed without your explicit approval. Generated by CodeGuardian AI |
CodeGuardian Review — PR #1Status: Completed (4/4 agents succeeded) Summary
Findings🟡 Medium
⚪ Low
Agent Status
Auto-Fix Available1 finding(s) have auto-generated fixes (test drafts, docstrings). No code is pushed without your explicit approval. Generated by CodeGuardian AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.