Make urllib3 optional.聽#965
Copy link
Copy link
Closed
Milestone
Description
Follow up to #963.
Let's ensure that the urllib3 dependency is optional.
- Make sure we don't have it anymore in
setup.py. - Make sure it's listed as optional in the
REAEDME/homepage. - Make sure that the
urllib3.pymodule passes gracefully onImportError, and checks the package exists inURLLib3Transport.__init__().
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
yeraydiazdiaz commentedon May 21, 2020
The last point is already covered, unless you have a different implementation in mind?
lovelydinosaur commentedon May 21, 2020
Ah fantastic!
lovelydinosaur commentedon May 21, 2020
Have also confirmed that it's not in
setup.py, so all we have is...urllib3is installed.README.mdanddoc/index.mdupdate the dependencies listing. (I guess moveurllib3to just abovebrotlipyas the other optional, and havehttpcorewithh11,h2hanging off as subdependancies, like so...httpcore- The default transport implementation forhttpx.h11- HTTP/1.1 support.h2- HTTP/2 support.certifi- SSL certificates.chardet- Fallback auto-detection for response encoding.hstspreload- determines whether IDNA-encoded host should be only accessed via HTTPS.idna- Internationalized domain name support.rfc3986- URL parsing & normalization.urllib3- Support forhttpx.URLLib3Transport(). (Optional)brotlipy- Decoding for "brotli" compressed responses. (Optional)